fix(codedeploy): ServerDeploymentGroup takes AutoScalingGroup instead of IAutoScalingGroup #9252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NetaNir
suggested changes
Aug 3, 2020
| @@ -703,6 +710,7 @@ export class AutoScalingGroup extends AutoScalingGroupBase implements | |||
|
|
|||
| this.autoScalingGroup = new CfnAutoScalingGroup(this, 'ASG', asgProps); | |||
| this.osType = imageConfig.osType; | |||
| this.operatingSystemType = imageConfig.osType; | |||
There was a problem hiding this comment.
Should we add an enum value of UNDEFINED to the OperatingSystemType Enum and keep one property?
There was a problem hiding this comment.
Sure. How about UNKNOWN for the third value?
There was a problem hiding this comment.
@NetaNir what do you want to do for OperatingSystemType.UNKNOWN for this function:
aws-cdk/packages/@aws-cdk/aws-ec2/lib/user-data.ts
Lines 88 to 93 in b80c271
NetaNir
approved these changes
Aug 3, 2020
skinny85
added
the
pr-linter/exempt-test
skinny85
force-pushed
the
fix/codedeploy-auto-scaling-groups
branch
from
e9a03c8 to
02ee36a
Compare
rix0rrr
approved these changes
Aug 7, 2020
skinny85
force-pushed
the
fix/codedeploy-auto-scaling-groups
branch
from
d3075fb to
2889f73
Compare
skinny85
force-pushed
the
fix/codedeploy-auto-scaling-groups
branch
from
2889f73 to
1d27838
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9175
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license